Re: [PATCH] mm: Use fallthrough;

From: Sergey Senozhatsky
Date: Sat Mar 07 2020 - 22:18:53 EST


On (20/03/06 23:58), Joe Perches wrote:
[..]
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -907,7 +907,6 @@ static void get_policy_nodemask(struct mempolicy *p, nodemask_t *nodes)
>
> switch (p->mode) {
> case MPOL_BIND:
> - /* Fall through */
> case MPOL_INTERLEAVE:
> *nodes = p->v.nodes;
> break;
> @@ -2092,7 +2091,6 @@ bool init_nodemask_of_mempolicy(nodemask_t *mask)
> break;
>
> case MPOL_BIND:
> - /* Fall through */
> case MPOL_INTERLEAVE:
> *mask = mempolicy->v.nodes;
> break;
> @@ -2359,7 +2357,6 @@ bool __mpol_equal(struct mempolicy *a, struct mempolicy *b)
>
> switch (a->mode) {
> case MPOL_BIND:
> - /* Fall through */
> case MPOL_INTERLEAVE:
> return !!nodes_equal(a->v.nodes, b->v.nodes);
> case MPOL_PREFERRED:

Ditto. This doesn't convert /* Fall through */ to fallthrough;

-ss