Re: [PATCHv4 01/11] videobuf2: add cache management members

From: Sergey Senozhatsky
Date: Sat Mar 07 2020 - 06:28:56 EST


On (20/03/07 11:10), Hans Verkuil wrote:
[..]
> >>> @@ -564,6 +573,7 @@ struct vb2_queue {
> >>> unsigned requires_requests:1;
> >>> unsigned uses_qbuf:1;
> >>> unsigned uses_requests:1;
> >>> + unsigned allow_cache_hints:1;
> >
> > Shall I use "unsigned int" here instead of "unsigned"?
>
> The vb2_queue bitfields are the only places in that header were 'unsigned' is
> used. I think that that should be fixed in a separate patch. It's nice to have
> it consistent.
>
> Put that patch in the beginning of the series, that way I can pick it up in the
> next pull request.

OK, done.

For the time being the series has moved to github public repo [0],
I'll try to run more 'twisty' cases and re-submit once it survives
beating.

[0] https://github.com/sergey-senozhatsky/v4l2-mmap-cache-flags

-ss