Re: Is this code chunk in init_apic_mappings() superfluous?

From: Thomas Gleixner
Date: Sat Mar 07 2020 - 06:28:33 EST


Cao jin <caoj.fnst@xxxxxxxxxxxxxx> writes:
> Hi,
>
> I am trying to figure the following code chunk out:
>
> if (x2apic_mode) {
> boot_cpu_physical_apicid = read_apic_id();
> return;
> }
>
> As my understanding, even in x2APIC mode, boot_cpu_physical_apicid is
> also got via early_acpi_process_madt --> ... --> register_lapic_address,
> so, is it for any corner case I am not aware?

The case when there are neither ACPI nor valid mptables. Unlikely, but
possible in theory.

Thanks,

tglx