Re: [PATCH v24 12/24] x86/sgx: Linux Enclave Driver

[Jarkko Sakkinen]

On Tue, 2020-01-14 at 10:12 -0600, Haitao Huang wrote:
> On Fri, 29 Nov 2019 17:13:14 -0600, Jarkko Sakkinen  
> <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> 
> > +static int sgx_encl_init(struct sgx_encl *encl, struct sgx_sigstruct  
> > *sigstruct,
> > +			 struct sgx_einittoken *token)
> > +{
> > +	u64 mrsigner[4];
> > +	int ret;
> > +	int i;
> > +	int j;
> > +
> > +	/* Check that the required attributes have been authorized. */
> > +	if (encl->secs_attributes & ~encl->allowed_attributes)
> > +		return -EINVAL;
> > +
> 
> EACCES to be more specific?

I'd say it'd be especially since it is our artificial access control
check and not something directly in the uarch. Thanks for the remark
I updated my master branch.

/Jarkko