Re: [PATCH 0/9] platform/x86: intel_pmc_ipc: Cleanups

[Andy Shevchenko]

On Wed, Jan 22, 2020 at 6:46 PM Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
>
> Hi,
>
> This is another independent cleanup series that I split out from my SCU/PMC
> IPC rework patch set [1] as suggested by Greg. This removes code that is
> not used anywhere and makes certain functions static as they are not called
> outside of the driver. We also make the driver to use driver->dev_groups to
> expose sysfs attributes.
>
> [1] https://lkml.org/lkml/2020/1/21/678
>

Pushed to my review and testing queue, thanks!

> Mika Westerberg (9):
>   platform/x86: intel_pmc_ipc: Make intel_pmc_gcr_update() static
>   platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_simple_command() static
>   platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_raw_cmd() static
>   platform/x86: intel_pmc_ipc: Drop intel_pmc_gcr_read() and intel_pmc_gcr_write()
>   platform/x86: intel_pmc_ipc: Drop ipc_data_readb()
>   platform/x86: intel_pmc_ipc: Get rid of unnecessary includes
>   platform/x86: intel_pmc_ipc: Use octal permissions in sysfs attributes
>   platform/x86: intel_pmc_ipc: Propagate error from kstrtoul()
>   platform/x86: intel_pmc_ipc: Switch to use driver->dev_groups
>
>  arch/x86/include/asm/intel_pmc_ipc.h |  32 --------
>  drivers/platform/x86/intel_pmc_ipc.c | 114 ++++-----------------------
>  2 files changed, 16 insertions(+), 130 deletions(-)
>
> --
> 2.24.1
>


-- 
With Best Regards,
Andy Shevchenko