Re: [PATCH] lib/rbtree: avoid pointless rb_node alignment

From: Andrew Morton
Date: Tue Jan 21 2020 - 16:04:54 EST


On Mon, 20 Jan 2020 09:51:44 -0800 Davidlohr Bueso <dave@xxxxxxxxxxxx> wrote:

> On Mon, 20 Jan 2020, Geert Uytterhoeven wrote:
>
> >timerqueue_del() uses rbtree, and
> >
> > #define rb_parent(r) ((struct rb_node *)((r)->__rb_parent_color & ~3))
> >
> >relies on all objects being 4-byte aligned. But your patch broke that
> >assumption on m68k, where the default alignment is 2-byte.
> >
> >Andrew: please drop this patch.
>
> Yeah that's too bad. I'll send a patch improving the comment around the alignment
> once the patch is dropped.

Thanks, I'll drop this patch.