Re: [PATCH] lib/rbtree: avoid pointless rb_node alignment

From: Davidlohr Bueso
Date: Mon Jan 20 2020 - 12:58:41 EST


On Mon, 20 Jan 2020, Geert Uytterhoeven wrote:

timerqueue_del() uses rbtree, and

#define rb_parent(r) ((struct rb_node *)((r)->__rb_parent_color & ~3))

relies on all objects being 4-byte aligned. But your patch broke that
assumption on m68k, where the default alignment is 2-byte.

Andrew: please drop this patch.

Yeah that's too bad. I'll send a patch improving the comment around the alignment
once the patch is dropped.

Thanks,
Davidlohr