Re: [PATCH net-next] devlink: Add health recover notifications on devlink flows

[Saeed Mahameed]

On Mon, 2020-01-20 at 10:50 +0100, David Miller wrote:
> From: Moshe Shemesh <moshe@xxxxxxxxxxxx>
> Date: Sun, 19 Jan 2020 17:04:28 +0200
> 
> > Devlink health recover notifications were added only on driver
> direct
> > updates of health_state through
> devlink_health_reporter_state_update().
> > Add notifications on updates of health_state by devlink flows of
> report
> > and recover.
> > 
> > Fixes: 97ff3bd37fac ("devlink: add devink notification when
> reporter update health state")
> > Signed-off-by: Moshe Shemesh <moshe@xxxxxxxxxxxx>
> > Acked-by: Jiri Pirko <jiri@xxxxxxxxxxxx>
> 
> I really dislike forward declarations and almost all of the time they
> are
> unnecessary.
> 

Hi Dave, a question just for educational purposes, i agree regarding
function forward declarations, bottom-up organizing should always be
followed. 

But how about type forward declaration ? for hiding struct details in
specifc c file.. is it a bad practice ?

I use this trick a lot in mlx5, for detail hiding and module separation
.. 

> Could you please just rearrange the code as needed and resubmit?
> 
> Thank you.