Re: [PATCH net-next] devlink: Add health recover notifications on devlink flows

From: Moshe Shemesh
Date: Mon Jan 20 2020 - 07:08:29 EST



On 1/20/2020 11:50 AM, David Miller wrote:
> From: Moshe Shemesh <moshe@xxxxxxxxxxxx>
> Date: Sun, 19 Jan 2020 17:04:28 +0200
>
>> Devlink health recover notifications were added only on driver direct
>> updates of health_state through devlink_health_reporter_state_update().
>> Add notifications on updates of health_state by devlink flows of report
>> and recover.
>>
>> Fixes: 97ff3bd37fac ("devlink: add devink notification when reporter update health state")
>> Signed-off-by: Moshe Shemesh <moshe@xxxxxxxxxxxx>
>> Acked-by: Jiri Pirko <jiri@xxxxxxxxxxxx>
> I really dislike forward declarations and almost all of the time they are
> unnecessary.
>
> Could you please just rearrange the code as needed and resubmit?
Sure, I will resubmit.
> Thank you.