Re: [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator

[Linus Walleij]

On Wed, Nov 6, 2019 at 6:33 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote:

> The USB regulator was removed for AB8500 in
> commit 41a06aa738ad ("regulator: ab8500: Remove USB regulator").
> It was then added for AB8505 in
> commit 547f384f33db ("regulator: ab8500: add support for ab8505").
>
> However, there was never an entry added for it in
> ab8505_regulator_match. This causes all regulators after it
> to be initialized with the wrong device tree data, eventually
> leading to an out-of-bounds array read.
>
> Given that it is not used anywhere in the kernel, it seems
> likely that similar arguments against supporting it exist for
> AB8505 (it is controlled by hardware).
>
> Therefore, simply remove it like for AB8500 instead of adding
> an entry in ab8505_regulator_match.
>
> Fixes: 547f384f33db ("regulator: ab8500: add support for ab8505")
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij