Re: [PATCH][next] xfrm: fix missing break on AF_INET6 case

From: Steffen Klassert
Date: Wed Jun 12 2019 - 06:44:46 EST


On Wed, Jun 12, 2019 at 11:36:24AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> It appears that there is a missing break statement for the AF_INET6 case
> that falls through to the default WARN_ONCE case. I don't think that is
> intentional. Fix this by adding in the missing break.
>
> Addresses-Coverity: ("Missing break in switch")
> Fixes: 4c203b0454b5 ("xfrm: remove eth_proto value from xfrm_state_afinfo")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

I have already a patch from Florian in queue to fix this.

Thanks anyway!