Re: Fwd: [PATCH -next] serial: stm32: Make stm32_get_databits static

From: Erwan LE RAY
Date: Wed Jun 05 2019 - 05:57:21 EST


OK for me.

Erwan.


On 6/5/19 9:08 AM, Fabrice Gasnier wrote:
> Un autre qu'on avait pas vu...
>
>
> -------- Forwarded Message --------
> Subject: [PATCH -next] serial: stm32: Make stm32_get_databits static
> Date: Tue, 28 May 2019 17:04:49 +0800
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
> To: gregkh@xxxxxxxxxxxxxxxxxxx, jslaby@xxxxxxxx,
> mcoquelin.stm32@xxxxxxxxx, alexandre.torgue@xxxxxx
> CC: YueHaibing <yuehaibing@xxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx,
> linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,
> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
> Fix sparse warning:
>
> drivers/tty/serial/stm32-usart.c:603:14: warning:
> symbol 'stm32_get_databits' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/tty/serial/stm32-usart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/stm32-usart.c
> b/drivers/tty/serial/stm32-usart.c
> index 9c2b04e..4517f2b 100644
> --- a/drivers/tty/serial/stm32-usart.c
> +++ b/drivers/tty/serial/stm32-usart.c
> @@ -600,7 +600,7 @@ static void stm32_shutdown(struct uart_port *port)
> free_irq(port->irq, port);
> }
> -unsigned int stm32_get_databits(struct ktermios *termios)
> +static unsigned int stm32_get_databits(struct ktermios *termios)
> {
> unsigned int bits;
> -- 2.7.4
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel