Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet

[èæ]

Thank you so much for your useful advice.

Pkshih <pkshih@xxxxxxxxxxx> ä2019å3æ20æåä äå10:31åéï
>
> On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote:
> > It is unnecessary to call spin_lock_bh in a tasklet.
> >
> > Signed-off-by: Jeff Xie <chongguiguzi@xxxxxxxxx>
> >
> > ---
> >  drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > index 48ca521..4055e0a 100644
> > --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw
> > *hw)
> >
> >                       memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
> >
> > -                     spin_lock_bh(&rtlpriv->locks.waitq_lock);
> > +                     spin_lock(&rtlpriv->locks.waitq_lock);
> >                       if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
> >                           (ring->entries - skb_queue_len(&ring->queue) >
> >                            rtlhal->max_earlymode_num)) {
> >                               skb = skb_dequeue(&mac->skb_waitq[tid]);
> >                       } else {
> > -                             spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> > +                             spin_unlock(&rtlpriv->locks.waitq_lock);
> >                               break;
> >                       }
> > -                     spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> > +                     spin_unlock(&rtlpriv->locks.waitq_lock);
> >
> >                       /* Some macaddr can't do early mode. like
> >                        * multicast/broadcast/no_qos data
>
> The mail subject should be 'rtlwifi: move ....', and the other looks good to me.
>
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
>