Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet

[Pkshih]

On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote:
> It is unnecessary to call spin_lock_bh in a tasklet.
> 
> Signed-off-by: Jeff Xie <chongguiguzi@xxxxxxxxx>
> 
> ---
> Âdrivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
> Â1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> b/drivers/net/wireless/realtek/rtlwifi/pci.c
> index 48ca521..4055e0a 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw
> *hw)
> Â
> Â			memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
> Â
> -			spin_lock_bh(&rtlpriv->locks.waitq_lock);
> +			spin_lock(&rtlpriv->locks.waitq_lock);
> Â			if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
> Â			ÂÂÂÂ(ring->entries - skb_queue_len(&ring->queue) >
> Â			ÂÂÂÂÂrtlhal->max_earlymode_num)) {
> Â				skb = skb_dequeue(&mac->skb_waitq[tid]);
> Â			} else {
> -				spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> +				spin_unlock(&rtlpriv->locks.waitq_lock);
> Â				break;
> Â			}
> -			spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> +			spin_unlock(&rtlpriv->locks.waitq_lock);
> Â
> Â			/* Some macaddr can't do early mode. like
> Â			Â* multicast/broadcast/no_qos data

The mail subject should be 'rtlwifi: move ....', and the other looks good to me.

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>