Re: [PATCH v2 2/4] crypto: hisilicon: Add queue management driver for HiSilicon QM module

[Zhou Wang]

On 2019/2/1 23:39, Herbert Xu wrote:
> On Fri, Feb 01, 2019 at 03:15:54PM +0800, Zhou Wang wrote:
>>
>>> Polling in softirq context is unacceptable.  Can't your hardware
>>> send interrupts to signal completion? What is the average speed
>>> of processing a single 1500-byte packet on your hardware?
>>
>> Our hardware supports interrupt. In fact, implementation of compress/decompress
>> interface of crypto_alg in v1 was done using interrupt:
>>
>>  compress/decompress:
>>      send task to hardware
>>      wait task finished(wait_for_completion_timeout)
>>
>>  In irq handler:
>>      complete
>>
>> However, there is get_cpu/put_cpu in scomp, wait and complete in above has to be
>> changed to poll:
>>
>>  compress/decompress:
>>      send task to hardware
>>      check if task is finished
> 
> If your hardware supports interrupts then you should be using
> the acomp interface and not scomp.

In fact, I planned to register to acomp later.

It also makes sense to use scomp if hardware engine is faster than CPU.
So how about registering to scomp firstly, then we register this engine to
acomp later?

Thanks,
Zhou

> 
> Thanks,
>