Re: [PATCH v2 2/4] crypto: hisilicon: Add queue management driver for HiSilicon QM module

[Herbert Xu]

On Fri, Feb 01, 2019 at 03:15:54PM +0800, Zhou Wang wrote:
>
> > Polling in softirq context is unacceptable.  Can't your hardware
> > send interrupts to signal completion? What is the average speed
> > of processing a single 1500-byte packet on your hardware?
> 
> Our hardware supports interrupt. In fact, implementation of compress/decompress
> interface of crypto_alg in v1 was done using interrupt:
> 
>  compress/decompress:
>      send task to hardware
>      wait task finished(wait_for_completion_timeout)
> 
>  In irq handler:
>      complete
> 
> However, there is get_cpu/put_cpu in scomp, wait and complete in above has to be
> changed to poll:
> 
>  compress/decompress:
>      send task to hardware
>      check if task is finished

If your hardware supports interrupts then you should be using
the acomp interface and not scomp.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt