Re: [PATCH] proc: return exit code 4 for skipped tests

From: Alexey Dobriyan
Date: Mon Jan 14 2019 - 15:12:02 EST


On Tue, Jan 08, 2019 at 07:33:19PM -0200, Thiago Jung Bauermann wrote:
> Alexey Dobriyan <adobriyan@xxxxxxxxx> writes:
> > --- a/tools/testing/selftests/proc/proc-loadavg-001.c
> > +++ b/tools/testing/selftests/proc/proc-loadavg-001.c
> > @@ -30,7 +30,7 @@ int main(void)
> >
> > if (unshare(CLONE_NEWPID) == -1) {
> > if (errno == ENOSYS || errno == EPERM)
> > - return 2;
> > + return 4;
> > return 1;
> > }
>
> Can't these tests use the KSFT_SKIP macro defined in kselftest.h?

They can! I tried to find a single use of XPASS and XFAIL and failed and
now I just don't want to have anything to do with that header.