Re: [PATCH] proc: return exit code 4 for skipped tests

From: Thiago Jung Bauermann
Date: Tue Jan 08 2019 - 16:33:36 EST



Alexey Dobriyan <adobriyan@xxxxxxxxx> writes:

> Test harness uses 4 for SKIP, not 2.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
>
> tools/testing/selftests/proc/proc-loadavg-001.c | 2 +-
> tools/testing/selftests/proc/proc-self-map-files-002.c | 2 +-
> tools/testing/selftests/proc/proc-self-syscall.c | 2 +-
> tools/testing/selftests/proc/proc-self-wchan.c | 2 +-
> tools/testing/selftests/proc/read.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> --- a/tools/testing/selftests/proc/proc-loadavg-001.c
> +++ b/tools/testing/selftests/proc/proc-loadavg-001.c
> @@ -30,7 +30,7 @@ int main(void)
>
> if (unshare(CLONE_NEWPID) == -1) {
> if (errno == ENOSYS || errno == EPERM)
> - return 2;
> + return 4;
> return 1;
> }

Can't these tests use the KSFT_SKIP macro defined in kselftest.h?

--
Thiago Jung Bauermann
IBM Linux Technology Center