Re: [PATCH v3 6/8] mfd / platform: cros_ec: instantiate only if th EC has a VBC NVRAM.

[Lee Jones]

On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:

> The cros-ec-vbc driver is DT-only and there is a DT property that
> indicates if the EC has the VCB NVRAM, in such case instantiate the
> driver but don't instantiate on the other cases.
> 
> To do this move the check code to its parent instead of play with the
> attribute group visibility. This changes a bit the actual behaviour.
> Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder
> is created in /sys/class/chromeos/<ec device>, after the patch the empty
> folder is not created, so, the folder is only created if the vbc is set.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> ---
> 
> Changes in v3:
> - Fixed build error as reported by kbuild test robot.
> 
> Changes in v2:
> - Remove unnecessary IS_ENABLED.
> - Remove dev_err message telling that VBC is found.
> - Use dev_warn instead of dev_err as the error is ignored.
> 
>  drivers/mfd/cros_ec_dev.c             | 19 ++++++++++++++++++-

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

>  drivers/platform/chrome/cros_ec_vbc.c | 16 ----------------

Isn't there anywhere better for this to reside?

>  2 files changed, 18 insertions(+), 17 deletions(-)

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog