Re: [PATCH v3 5/8] mfd / platform: cros_ec: move device sysfs attributes to its own driver.

From: Lee Jones
Date: Mon Dec 03 2018 - 05:56:24 EST


On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:

> The entire way how cros debugfs attibutes are created is broken.
> cros_ec_sysfs should be its own driver and its attributes should be
> associated with the sysfs driver not the mfd driver.
>
> The patch also adds the sysfs documentation.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> ---
>
> Changes in v3:
> - Do not print ec_platform name as is with dev_err is enough.
>
> Changes in v2:
> - Create the attributes directly instead of use the attach/detach callbacks.
>
> .../ABI/testing/sysfs-class-chromeos | 32 +++++++++++++++++
> drivers/platform/chrome/Kconfig | 14 ++++++--
> drivers/platform/chrome/Makefile | 3 +-
> drivers/platform/chrome/cros_ec_sysfs.c | 36 ++++++++++++++++++-

> drivers/mfd/Kconfig | 1 -
> drivers/mfd/cros_ec_dev.c | 7 +---
> include/linux/mfd/cros_ec.h | 3 --

For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog