Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

[Michael Hennerich]

On 09.07.2018 23:51, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>   drivers/video/backlight/adp8860_bl.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 16119bd..f1dc41c 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
>   	switch (ADP8860_MANID(reg_val)) {
>   	case ADP8863_MANUFID:
>   		data->gdwn_dis = !!pdata->gdwn_dis;
> +		/* fall through */
>   	case ADP8860_MANUFID:
>   		data->en_ambl_sens = !!pdata->en_ambl_sens;
>   		break;


--
Greetings,
Michael

--
Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 MÃnchen
Sitz der Gesellschaft MÃnchen, Registergericht MÃnchen HRB 40368,
GeschÃftsfÃhrer: Peter Kolberg, Ali Raza Husain, Eileen Wynne