Re: [PATCH 3/4] PCI: dwc: dra7xx: Add support for SoC specific compatible strings

From: Bjorn Helgaas
Date: Tue Oct 17 2017 - 15:23:24 EST


s/PCI: dwc: dra7xx: Add support for SoC specific compatible strings/
PCI: dra7xx: Add dra726 and dra746 compatible strings/

I think including "dwc" makes sense for things that involve the DW
core, but this is really dra7xx-specific. And I think the *support*
for SoC-specific strings was already there; it looks like this patch
simply adds some of those strings.

On Tue, Oct 10, 2017 at 03:46:05PM +0530, Kishon Vijay Abraham I wrote:
> dra74x/dra76x and dra72x has separate compatible strings. Add support
> for these compatible strings in pci-dra7xx driver.

s/has separate/have separate/

> This is a preparatory patch for adding 2-lane mode support and
> dra74/dra72 should add it's own driver data for 2-lane mode
> configuration.

s/it's/its/

> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 362607f727ee..78a87a8f1362 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -542,6 +542,22 @@ static const struct of_device_id of_dra7xx_pcie_match[] = {
> .compatible = "ti,dra7-pcie-ep",
> .data = &dra7xx_pcie_ep_of_data,
> },
> + {
> + .compatible = "ti,dra746-pcie-rc",
> + .data = &dra7xx_pcie_rc_of_data,
> + },
> + {
> + .compatible = "ti,dra746-pcie-ep",
> + .data = &dra7xx_pcie_ep_of_data,
> + },
> + {
> + .compatible = "ti,dra726-pcie-rc",
> + .data = &dra7xx_pcie_rc_of_data,
> + },
> + {
> + .compatible = "ti,dra726-pcie-ep",
> + .data = &dra7xx_pcie_ep_of_data,
> + },
> {},
> };
>
> --
> 2.11.0
>