[PATCH v2] of: dynamic: fix memory leak related to properties of __of_node_dup

From: Lixin Wang
Date: Tue Oct 17 2017 - 00:21:37 EST


If a node with no properties is dynamically added, then a property is
dynamically added to the node, then the property is dynamically removed,
the result will be node->properties == NULL and node->deadprops != NULL.

Signed-off-by: Lixin Wang <alan.1.wang@xxxxxxxxxxxxxxx>
---
v1:
* Change the description of this patch as suggested by Frank Rowand.

drivers/of/dynamic.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index 301b6db..465d43b 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -335,6 +335,10 @@ void of_node_release(struct kobject *kobj)
if (!of_node_check_flag(node, OF_DYNAMIC))
return;

+ if (!prop) {
+ prop = node->deadprops;
+ node->deadprops = NULL;
+ }
while (prop) {
struct property *next = prop->next;
kfree(prop->name);
--
2.6.2