Re: [PATCH v8 09/15] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

From: kbuild test robot
Date: Tue Oct 17 2017 - 00:21:14 EST


Hi Mario,

[auto build test ERROR on platform-drivers-x86/for-next]
[also build test ERROR on v4.14-rc5 next-20171016]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Mario-Limonciello/Introduce-support-for-Dell-SMBIOS-over-WMI/20171017-103109
base: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next
config: x86_64-randconfig-x013-201742 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

Note: the linux-review/Mario-Limonciello/Introduce-support-for-Dell-SMBIOS-over-WMI/20171017-103109 HEAD 73d71487dc3728417e851f3fac100ee4d6cdebd1 builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

drivers/platform/x86/dell-smbios.c: In function 'location_show':
drivers/platform/x86/dell-smbios.c:238:7: error: implicit declaration of function 'capable' [-Werror=implicit-function-declaration]
if (!capable(CAP_SYS_ADMIN))
^~~~~~~
>> drivers/platform/x86/dell-smbios.c:238:15: error: 'CAP_SYS_ADMIN' undeclared (first use in this function)
if (!capable(CAP_SYS_ADMIN))
^~~~~~~~~~~~~
drivers/platform/x86/dell-smbios.c:238:15: note: each undeclared identifier is reported only once for each function it appears in
drivers/platform/x86/dell-smbios.c: In function 'value_show':
drivers/platform/x86/dell-smbios.c:252:15: error: 'CAP_SYS_ADMIN' undeclared (first use in this function)
if (!capable(CAP_SYS_ADMIN))
^~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/CAP_SYS_ADMIN +238 drivers/platform/x86/dell-smbios.c

0b0f338a Mario Limonciello 2017-10-14 232
0b0f338a Mario Limonciello 2017-10-14 233 static ssize_t location_show(struct device *dev,
0b0f338a Mario Limonciello 2017-10-14 234 struct device_attribute *attr, char *buf)
0b0f338a Mario Limonciello 2017-10-14 235 {
0b0f338a Mario Limonciello 2017-10-14 236 int i;
0b0f338a Mario Limonciello 2017-10-14 237
0b0f338a Mario Limonciello 2017-10-14 @238 if (!capable(CAP_SYS_ADMIN))
0b0f338a Mario Limonciello 2017-10-14 239 return -EPERM;
0b0f338a Mario Limonciello 2017-10-14 240
0b0f338a Mario Limonciello 2017-10-14 241 i = match_attribute(dev, attr);
0b0f338a Mario Limonciello 2017-10-14 242 if (i > 0)
0b0f338a Mario Limonciello 2017-10-14 243 return scnprintf(buf, PAGE_SIZE, "%08x", da_tokens[i].location);
0b0f338a Mario Limonciello 2017-10-14 244 return 0;
0b0f338a Mario Limonciello 2017-10-14 245 }
0b0f338a Mario Limonciello 2017-10-14 246

:::::: The code at line 238 was first introduced by commit
:::::: 0b0f338a482cc8b1f4807887c866d7095d8d1b16 platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

:::::: TO: Mario Limonciello <mario.limonciello@xxxxxxxx>
:::::: CC: 0day robot <fengguang.wu@xxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip