Re: [PATCH 031/102] iio: adc: rockchip_saradc: explicitly request exclusive reset control

From: Jonathan Cameron
Date: Sun Aug 20 2017 - 07:09:22 EST


On Wed, 19 Jul 2017 17:25:35 +0200
Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:

> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Hartmut Knaack <knaack.h@xxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
> drivers/iio/adc/rockchip_saradc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index ae6d3324f5183..1d9300ba07c00 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -235,7 +235,8 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
> * The reset should be an optional property, as it should work
> * with old devicetrees as well
> */
> - info->reset = devm_reset_control_get(&pdev->dev, "saradc-apb");
> + info->reset = devm_reset_control_get_exclusive(&pdev->dev,
> + "saradc-apb");
> if (IS_ERR(info->reset)) {
> ret = PTR_ERR(info->reset);
> if (ret != -ENOENT)