Re: [PATCH 032/102] iio: dac: stm32-dac-core: explicitly request exclusive reset control

From: Jonathan Cameron
Date: Sun Aug 20 2017 - 07:09:21 EST


On Wed, 19 Jul 2017 17:25:36 +0200
Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:

> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Hartmut Knaack <knaack.h@xxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan

> ---
> drivers/iio/dac/stm32-dac-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c
> index 75e48788c7ead..f1eeb1549f689 100644
> --- a/drivers/iio/dac/stm32-dac-core.c
> +++ b/drivers/iio/dac/stm32-dac-core.c
> @@ -114,7 +114,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
> goto err_vref;
> }
>
> - priv->rst = devm_reset_control_get(dev, NULL);
> + priv->rst = devm_reset_control_get_exclusive(dev, NULL);
> if (!IS_ERR(priv->rst)) {
> reset_control_assert(priv->rst);
> udelay(2);