Re: [PATCH] net: stmmac: do not call phy_ethtool_ksettings_set from atomic context

From: David Miller
Date: Wed Dec 07 2016 - 13:09:19 EST


From: Niklas Cassel <niklas.cassel@xxxxxxxx>
Date: Tue, 6 Dec 2016 14:47:15 +0100

> From: Niklas Cassel <niklas.cassel@xxxxxxxx>
>
> From what I can tell, spin_lock(&priv->lock) is not needed, since the
> phy_ethtool_ksettings_set call is not given the priv struct.
>
> phy_start_aneg takes the phydev->lock. Calls to phy_adjust_link
> from phy_state_machine also takes the phydev->lock.
...
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxx>

Applied, but please always be explicit about what tree you are targetting
this patch by properly annotating for it in your Subject line.

In this case that would be "Subject: [PATCH net-next] ..."