Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h

[Frans Klaver]

On Tue, Aug 23, 2016 at 1:30 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Mikko Rapeli <mikko.rapeli@xxxxxx>
> Date: Mon, 22 Aug 2016 20:32:44 +0200
>
>> Fixes userspace compiler error:
>>
>> error: âIFNAMSIZâ undeclared here (not in a function)
>>
>> Suggested by Frans Klaver <fransklaver@xxxxxxxxx> on lkml message
>> <20150530195223.GA15645@xxxxxxxxxxx>.
>>
>> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
>
> IFNAMSIZ has to be in linux/if.h, you aren't explaining why you have
> to move it to the hdlc header instead of having the hdlc header
> include linux/if.h

Circular references. linux/if.h includes hdlc/ioctl.h, and has to
define IFNAMSIZ before doing so. If IFNAMSIZ is moved to hdlc/ioctl.h,
it is still pulled in if one includes linux/if.h. What we gain is that
you can include hdlc/ioctl.h directly (which is what one of the tests
is already doing, iirc).

But yes, it should be explained in the commit message.

Thanks,
Frans