Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h

From: David Miller
Date: Mon Aug 22 2016 - 19:30:43 EST


From: Mikko Rapeli <mikko.rapeli@xxxxxx>
Date: Mon, 22 Aug 2016 20:32:44 +0200

> Fixes userspace compiler error:
>
> error: ʽIFNAMSIZʼ undeclared here (not in a function)
>
> Suggested by Frans Klaver <fransklaver@xxxxxxxxx> on lkml message
> <20150530195223.GA15645@xxxxxxxxxxx>.
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>

IFNAMSIZ has to be in linux/if.h, you aren't explaining why you have
to move it to the hdlc header instead of having the hdlc header
include linux/if.h

And if your reason is legitimate, you have to add that explanation to
the patch commit log message.