Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ?

From: Greg KH
Date: Mon Aug 22 2016 - 10:30:18 EST


On Mon, Aug 22, 2016 at 03:07:44PM +0100, David Binderman wrote:
> Hello there,
>
> linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]:
> (style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always
> true
>
> Source code is
>
> if (pBtMgnt->ExtConfig.HCIExtensionVer < 1) {
> ....
> } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {
>
> Suggest remove second test.

patches are always welcome :)