Re: [PATCH 01/13] scpi: Add vendor_send_message to enable access to vendor commands

From: Sudeep Holla
Date: Thu Aug 18 2016 - 21:23:42 EST




On 18/08/16 11:10, Neil Armstrong wrote:
Adds an optional vendor_send_message to the scpi to enable sending
vendor platform specific commands to the SCP firmware.


I don't see any users of vendor_send_message in this series, so I prefer
it to be dropped and introduced when required.

Also I had a different view on how to introduce this[1]. I would rather
wait until the requirement comes that enables us to make use of it.
Looks like you took parts of it and introduces vendor_send_message
allowing users to send any data which I don't like especially without
knowing how will it be (ab)used.

--
Regards,
Sudeep

[1] http://www.spinics.net/lists/kernel/msg2263649.html