Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

From: Linus Walleij
Date: Wed Aug 10 2016 - 18:14:35 EST


On Wed, Aug 10, 2016 at 5:17 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:

> Guess what, I just found this exact sucker in the pile of
> "junk we won't ever use because it can't run mainline".
> I even booted one of your test images on it.
>
> Do you have a tree I can clone directly, with all the ugly patches
> applied?

Yeah:
https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-integrator.git/log/?h=apq8060-dragonboard-ethernet

The apq8060-dragonboard branch is clean (just necessary boot fixes,
the flag fixes and the revert), gives the right IRQs:
https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-integrator.git/log/?h=apq8060-dragonboard

The webpage gives the details of how I build, my Makefile and
initramfs.cpio etc if you want:
https://dflund.se/~triad/krad/dragonboard/

>>> Do you see this symptom on all chained interrupts? Or just this
>>> particular one?
>>
>> This appears on all IRQs on the PM (MFD) ASIC.
>
> These interrupts?
>
> 197: 1 0 pm8xxx 50 Edge pmic8xxx_pwrkey_release
> 198: 1 0 pm8xxx 51 Edge pmic8xxx_pwrkey_press
> 199: 8 0 pm8xxx 74 Edge pmic-keypad
> 200: 0 0 pm8xxx 75 Edge pmic-keypad-stuck
> 201: 0 0 pm8xxx 39 Edge pm8xxx_rtc_alarm

Yes. Doesn' appear anymore in v4.8-rc1

> How is the interrupt topology built? pm8085 -> tlmm -> GIC?

Yes AFAICT.

pm8058 -> tlmm hwirq 88 -> GIC hwirq 16

Yours,
Linus Walleij