Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

From: Guenter Roeck
Date: Wed Aug 03 2016 - 14:03:39 EST


On Wed, Aug 3, 2016 at 2:18 AM, Oliver Neukum <oneukum@xxxxxxxx> wrote:
> On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
>> +static int tcpm_set_polarity(struct tcpm_port *port,
>> + enum typec_cc_polarity polarity)
>> +{
>> + tcpm_log(port, "polarity %d", polarity);
>> +
>> + port->polarity = polarity;
>> +
>> + return port->tcpc->set_polarity(port->tcpc, port->polarity);
>> +}
>
> Here you don't care about the result.

Changed to only set port->polarity if the set_polarity callback was successful.

Thanks,
Guenter