Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

From: Oliver Neukum
Date: Wed Aug 03 2016 - 05:35:16 EST


On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
> +static bool svdm_consume_svids(struct tcpm_port *port, const u32
> *payload,
> + int cnt)
> +{
> + struct pd_mode_data *pmdata = &port->mode_data;
> + int i;
> +
> + for (i = 1; i < cnt; i++) {
> + u16 svid;
> +
> + svid = (payload[i] >> 16) & 0xffff;
> + if (!svid)
> + return false;

Hi,

this looks like an endianness bug.

Regards
Oliver