Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get_virq() error code

[Javier Martinez Canillas]

Hello Krzysztof,

On 02/03/2016 09:26 PM, Krzysztof Kozlowski wrote:
> The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions
> but driver checked only for value of 0.
>
> This could lead to a cast of -EINVAL to an unsigned int used as a
> interrupt number for devm_request_threaded_irq(). Although this is not
> yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but
> might be a misleading when diagnosing errors.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Fixes: 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq")
>
> ---

Good catch.

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America