Re: [PATCH] MAINTAINERS: fix entry of char/misc

From: Joe Perches
Date: Tue Oct 13 2015 - 13:35:35 EST


On Tue, 2015-10-13 at 22:49 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> > On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> > > Greg and Arnd are supporter of char and misc drivers. While using
> > > getmaintainer.pl on any patch or any file in these directories their
> > > names were never displayed.
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > > M: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > S: Supported
> > > -F: drivers/char/*
> > > -F: drivers/misc/*
> > > +F: drivers/char/
> > > +F: drivers/misc/
> > > F: include/linux/miscdevice.h
> >
> > Do Greg and Arnd really want to be supporting all
> > subsystems below drivers/char like agp and xillybus?
>
> I don't know that. Maybe Greg and Arnd can say.
> But wasn't that the intention when char/* *nd misc/* was mentioned here?

No.

It was specific to files that are only in the top level
directories drivers/char/ and drivers/misc/ but not any
files in directories below those.

There should be some difference between S: uses for
some of the char and misc bits.

Besides, as commit 46e642614b36 shows, Greg and Arnd are
self-described fools...

Still, it may be sensible have 2 MAINTAINERS sections like:

CHAR and MISC CORE
M: Arnd Bergmann <arnd@xxxxxxxx>
M: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported
F: drivers/char/*
F: drivers/misc/*
F: include/linux/miscdevice.h

CHAR and MISC DRIVERS
M: Arnd Bergmann <arnd@xxxxxxxx>
M: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Odd fixes
F: drivers/char/
F: drivers/misc/

but maybe there should be some exclusions in the
drivers block like:

X: drivers/char/hw_random/
X: drivers/char/ipmi/

and probably some others.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/