Re: [PATCH] Staging: fbtft: Fix iomem dereference

From: Ronit Halder
Date: Tue Aug 18 2015 - 09:38:25 EST


Yes, it is not I/O memory address. I was wrong on that.
But it makes sparse happy.
Is here any side effect of using ioread16() ?

regards,
ronit

On Tue, Aug 18, 2015 at 2:27 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Tue, Aug 18, 2015 at 12:16:57PM +0530, Ronit Halder wrote:
>> This patch fixes the warning generated by sparse
>> "cast removes address space of expression" by using ioread16
>> function insted of directly dereferencing I/O memory.
>>
>> Signed-off-by: Ronit halder <ronit.crj@xxxxxxxxx>
>
> Are these really iomem pointers? A lot of drivers use a fake
> screen_base which is just a buffer of normal memory.
>
> regards,
> dan carpenter
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/