Re: Dealing with the NMI mess

[Steven Rostedt]

On Fri, 24 Jul 2015 18:08:06 +0200
Willy Tarreau <w@xxxxxx> wrote:


> > Um, isn't 0xf * DR_TRAP0 same as a constant "true"?
> 
> For me it's a typo, it should have been :
> 
>  if ((dr6 & (0xf * DR_TRAP0) && (regs->flags & (X86_EFLAGS_RF |
> 
> (the purpose was to read all 4 lower bits at once).

I figured that after I sent it, but the 0xf * DR_TRAP0 is also
confusing to me. Actually, why not use proper naming:

  dr6 & DR_TRAP_BITS

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/