Re: Dealing with the NMI mess

[Willy Tarreau]

On Fri, Jul 24, 2015 at 12:02:49PM -0400, Steven Rostedt wrote:
> On Fri, 24 Jul 2015 08:48:57 -0700
> Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
> 
> > So by the time we detect that we've hit a watchpoint, the instruction
> > that tripped it is done and we don't need RF.  Furthermore, after
> > reading 17.3.1.1: I *think* that regs->flags withh have RF *clear* if
> > we hit a watchpoint.  So this might be as simple as:
> > 
> > if ((dr6 && (0xf * DR_TRAP0) && (regs->flags & (X86_EFLAGS_RF |
> 
> Um, isn't 0xf * DR_TRAP0 same as a constant "true"?

For me it's a typo, it should have been :

 if ((dr6 & (0xf * DR_TRAP0) && (regs->flags & (X86_EFLAGS_RF |

(the purpose was to read all 4 lower bits at once).

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/