Re: [RFC V2] init: support device of major:minor:offset format

From: Geert Uytterhoeven
Date: Wed May 06 2015 - 12:49:57 EST


On Wed, May 6, 2015 at 2:24 AM, Chen Yu <yu.c.chen@xxxxxxxxx> wrote:
> Distribution like Ubuntu uses klibc rather than uswsusp to resume
> system from hibernation, which will treat swap partition/file in
> the form of major:minor:offset. For example, 8:3:0 represents a
> swap partition in klibc, and klibc's resume process in initrd will
> finally echo 8:3:0 to /sys/power/resume for manually restoring.
> However in current implementation, 8:3:0 will be treated as an invalid

Why can't klibc write the same information as uswsusp?
Why should the kernel adapt to a specific piece of userspace?

> device format, and it is found that manual resumming from hibernation
> will fail on lastest kernel.

Is this a regression, perhaps introduced by commit 283e7ad024115571
("init: stricter checking of major:minor root= values")? If that is the case,
please say so.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/