Re: [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin

[Greg Kroah-Hartman]

On Sat, Apr 04, 2015 at 05:51:21AM +0800, Chen Gang wrote:
> Under blackfin, only bf527, bf548 and bf609 may use musb. The related
> error with allmodconfig:
> 
>     CC [M]  drivers/usb/misc/trancevibrator.o
>   In file included from drivers/usb/musb/musb_core.h:70:0,
>                    from drivers/usb/musb/musb_core.c:103:
>   drivers/usb/musb/musb_core.c: In function 'musb_indexed_ep_select':
>   drivers/usb/musb/musb_regs.h:458:32: error: 'USB_INDEX' undeclared (first use in this function)
>    #define MUSB_INDEX  USB_OFFSET(USB_INDEX) /* 8 bit */
>                                   ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx>

Why not fix the root cause and provide this symbol on blackfin?  There's
no specific reason why it shouldn't be able to be built on this
platform.

It's better to make platforms properly build everything, patches like
this just make things messier and harder to maintain.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/