Re: [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin

[Chen Gang]

On 4/4/15 06:03, Richard Weinberger wrote:
> On Fri, Apr 3, 2015 at 11:51 PM, Chen Gang <xili_gchen_5257@xxxxxxxxxxx> wrote:
>> Under blackfin, only bf527, bf548 and bf609 may use musb. The related
>> error with allmodconfig:
>>
>>     CC [M]  drivers/usb/misc/trancevibrator.o
>>   In file included from drivers/usb/musb/musb_core.h:70:0,
>>                    from drivers/usb/musb/musb_core.c:103:
>>   drivers/usb/musb/musb_core.c: In function 'musb_indexed_ep_select':
>>   drivers/usb/musb/musb_regs.h:458:32: error: 'USB_INDEX' undeclared (first use in this function)
>>    #define MUSB_INDEX  USB_OFFSET(USB_INDEX) /* 8 bit */
>>                                   ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx>
>> ---
>>  drivers/usb/musb/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>> index 39db8b6..5fca898 100644
>> --- a/drivers/usb/musb/Kconfig
>> +++ b/drivers/usb/musb/Kconfig
>> @@ -6,7 +6,7 @@
>>  # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
>>  config USB_MUSB_HDRC
>>         tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
>> -       depends on (USB || USB_GADGET)
>> +       depends on (USB || USB_GADGET) && (!BLACKFIN || (BLACKFIN && (BF527 || BF548 || BF609)))
> 
> This is ugly.
> Can't you add a new Kconfig symbol in arch/blackfin and change the
> #ifndef CONFIG_BLACKFIN
> in drivers/usb/musb/musb_regs.h to it?
> 

For me, for configuration, we need to try to finish them in Kconfig and
keep the .c or .h source code no touch.

But it is really not quite well to let machine details (e.g. BF527,
BF548, BF609) in the outside of "arch/blackfin".

So, I guess, we need to add new config value HAVE_MUSB for it in patch
v2.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/