Re: [PATCH v1 1/2] x86: kconfig: remove X86_UP_IOAPIC

From: Bryan O'Donoghue
Date: Wed Mar 11 2015 - 21:19:21 EST


On 11/03/15 23:10, Luis R. Rodriguez wrote:

ACK the concept - the logic to compile up APIC support is circuitous to say the least.

Personally think we should just always compile up the APIC code if the arch declares support and let the bootstrap code interrogate CPUID. Who in 2015 is really running a system without an APIC/IO-APIC and tip-of-tree Linux and does that one user care about adding 12k to her kernel ? I suspect not and in any case can force the APIC off with a command line argument

@@ -899,6 +899,7 @@ config X86_UP_APIC
bool "Local APIC support on uniprocessors" if !PCI_MSI

Tried to apply this to torvalds-master to test :( Should it ? Which branch are you on here ?

Applying: x86: kconfig: remove X86_UP_IOAPIC
error: patch failed: arch/x86/Kconfig:899
error: arch/x86/Kconfig: patch does not apply
Patch failed at 0001 x86: kconfig: remove X86_UP_IOAPIC

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/