Re: [PATCH 1/6] zram: remove `num_migrated' device attr

From: Minchan Kim
Date: Wed Mar 11 2015 - 21:16:59 EST


On Wed, Mar 11, 2015 at 12:08:29AM +0900, Sergey Senozhatsky wrote:
> Remove sysfs `num_migrated' attribute. We are moving away from
> per-stat device attrs towards 3 stat files that will accumulate
> io and mm stats in a format similar to block layer statistics in
> /sys/block/<dev>/stat. That will be easier to use in user space,
> and reduce the number of syscalls needed to read zram device
> statistics.
>
> `num_migrated' will return back in zram<id>/mm_stat file.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

> ---
> Documentation/ABI/testing/sysfs-block-zram | 7 -------
> drivers/block/zram/zram_drv.c | 2 --
> 2 files changed, 9 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-block-zram b/Documentation/ABI/testing/sysfs-block-zram
> index bede902..91ad707 100644
> --- a/Documentation/ABI/testing/sysfs-block-zram
> +++ b/Documentation/ABI/testing/sysfs-block-zram
> @@ -149,10 +149,3 @@ Description:
> The compact file is write-only and trigger compaction for
> allocator zrm uses. The allocator moves some objects so that
> it could free fragment space.
> -
> -What: /sys/block/zram<id>/num_migrated
> -Date: August 2015
> -Contact: Minchan Kim <minchan@xxxxxxxxxx>
> -Description:
> - The compact file is read-only and shows how many object
^^^^^

Argh, I believe you will correct it in later patch.

Thanks.

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/