Re: [wsa:i2c/quirks 7/11] drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

From: Fengguang Wu
Date: Thu Jan 08 2015 - 16:51:43 EST


Hi Wolfram,

On Thu, Jan 08, 2015 at 07:28:48PM +0100, Wolfram Sang wrote:
> On Fri, Jan 09, 2015 at 01:57:37AM +0800, kbuild test robot wrote:
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
> > head: b1d39af8ae21f4930854b0656aa83a83fd38049e
> > commit: 70181ecd2990326a91edb3dac1db4cce21e561f7 [7/11] i2c: axxia: make use of the new infrastructure for quirks
> > reproduce:
> > # apt-get install sparse
> > git checkout 70181ecd2990326a91edb3dac1db4cce21e561f7
> > make ARCH=x86_64 allmodconfig
> > make C=1 CF=-D__CHECK_ENDIAN__
> >
> >
> > sparse warnings: (new ones prefixed by >>)
> >
> > >> drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?
> >
> > Please review and possibly fold the followup patch.
>
> Yes, it should be static.
>
> However, this is a development branch and in this case it would be
> enough if the test results would be directed to me only.

It's normally private emails, except for the ones that carry patches
with them. In which case public mailing lists will also be CCed.

> Is there a way to achieve this? I know that adding "experimental" to the
> branch name will skip the testing. Is there another pattern to prevent
> sending mails to everyone?

I wonder if the occasional public emails are acceptable to you. If
not, it'd be trivial for me to add a list of "personal git trees"
where all emails including the auto generated patches will be kept
private (if commit author == committer).

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/