Re: [PATCH v2 2/3] x86_64,vsyscall: Rewrite comment and clean up headers in vsyscall code

From: Thomas Gleixner
Date: Mon Nov 03 2014 - 15:31:14 EST


On Wed, 29 Oct 2014, Andy Lutomirski wrote:

> vsyscall_64.c is just vsyscall emulation. Tidy it up accordingly.
>
> If my comment editing offends anyone, let me know and I can fix it.
>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> ---
> arch/x86/kernel/vsyscall_64.c | 51 +++++++++++++++----------------------------
> 1 file changed, 18 insertions(+), 33 deletions(-)
>
> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
> index 2d912629c96e..ee622f8183f3 100644
> --- a/arch/x86/kernel/vsyscall_64.c
> +++ b/arch/x86/kernel/vsyscall_64.c
> @@ -1,52 +1,37 @@
> /*
> - * Copyright (C) 2001 Andrea Arcangeli <andrea@xxxxxxx> SuSE
> - * Copyright 2003 Andi Kleen, SuSE Labs.
> + * Mostly copyright (c) 2012-2014 Andy Lutomirski <luto@xxxxxxxxxxxxxx>

We usualy leave the old copyright notices around even if the code
which is related to them has been removed more or less completely.

So I change this to:

/*
* Copyright (c) 2012-2014 Andy Lutomirski <luto@xxxxxxxxxxxxxx>
*
* Based on the original implementation:
* Copyright (C) 2001 Andrea Arcangeli <andrea@xxxxxxx> SuSE
* Copyright 2003 Andi Kleen, SuSE Labs.

and apply the whole lot.

Thanks,

tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/