Re: [PATCH 00/33] thermal: exynos: convert the driver to use per-SoC type operations

From: Eduardo Valentin
Date: Wed Oct 29 2014 - 22:44:49 EST


Bartlomiej,

On Thu, Sep 18, 2014 at 05:27:17PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> This patch series replaces the hardware registers abstractions in
> the Exynos thermal driver by the usage of per-SoC type operations.
> Such solution provides simpler, easier to understand code and
> allows removal of ~250 LOCs (~11% of the whole source code) from
> the driver. Some other driver improvements are now also possible
> thanks to these changes but are scheduled at later time (like
> consolidating code for clearing IRQs using INTCLEAR register).
>
> The patchset should not cause any functionality changes. This
> means that unless there are some bugs in the patches itself there
> should be no behavior changes for the driver (this also includes
> lack of changes in the way hardware is accessed by the driver).
>
> All testing was done on (Exynos4412 SoC based) ODROID U3 board
> (some additional patches are needed to make the Exynos thermal
> driver work on this hardware).
>
> Depends on:
> - 'next' branch of linux-soc-thermal.git kernel tree from Eduardo
> - [PATCH] thermal: exynos: use correct offset for TMU_CONTROL
> register on Exynos5260
> (http://www.mail-archive.com/linux-samsung-soc@xxxxxxxxxxxxxxx/msg36529.html)
>

Could you please refresh this series?

I checked until patch 09, but patch 10 fails to apply:
patching file drivers/thermal/samsung/exynos_tmu.c
Hunk #1 succeeded at 414 (offset 15 lines).
patching file drivers/thermal/samsung/exynos_tmu.h
Hunk #1 succeeded at 92 with fuzz 2 (offset -4 lines).
Hunk #2 succeeded at 117 (offset -8 lines).
patching file drivers/thermal/samsung/exynos_tmu_data.c
Hunk #1 FAILED at 422.
1 out of 1 hunk FAILED -- saving rejects to file
drivers/thermal/samsung/exynos_tmu_data.c.rej

I also have in my local tree the dependency patch you mention above.

Cheers,

> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>
> Bartlomiej Zolnierkiewicz (33):
> thermal: exynos: remove needless triminfo_data abstraction
> thermal: exynos: remove needless tmu_status abstraction
> thermal: exynos: remove needless threshold_temp abstraction
> thermal: exynos: remove needless triminfo_ctrl abstraction
> thermal: exynos: remove needless test_mux_addr_shift abstraction
> thermal: exynos: remove needless therm_trip_[mode,mask]_shift
> abstractions
> thermal: exynos: remove needless therm_trip_en_shift abstraction
> thermal: exynos: remove needless emul_temp_shift abstraction
> thermal: exynos: remove needless emul_time_shift abstraction
> thermal: exynos: replace tmu_irqstatus check by Exynos5440 one
> thermal: exynos: replace tmu_pmin check by Exynos5440 one
> thermal: exynos: simplify HW_TRIP level setting
> thermal: exynos: replace threshold_falling check by Exynos SoC type
> one
> thermal: exynos: remove TMU_SUPPORT_READY_STATUS flag
> thermal: exynos: remove TMU_SUPPORT_TRIM_RELOAD flag
> thermal: exynos: add sanitize_temp_error() helper
> thermal: exynos: add get_th_reg() helper
> thermal: exynos: add ->tmu_initialize method
> thermal: exynos: add get_con_reg() helper
> thermal: exynos: add ->tmu_control method
> thermal: exynos: add ->tmu_read method
> thermal: exynos: add get_emul_con_reg() helper
> thermal: exynos: add ->tmu_set_emulation method
> thermal: exynos: add ->tmu_clear_irqs method
> thermal: exynos: remove TMU_SUPPORT_FALLING_TRIP flag
> thermal: exynos: remove TMU_SUPPORT_EMUL_TIME flag
> thermal: exynos: remove TMU_SUPPORT_EMULATION flag
> thermal: exynos: remove TMU_SUPPORT_ADDRESS_MULTIPLE flag
> thermal: exynos: remove TMU_SUPPORT_MULTI_INST flag
> thermal: exynos: remove test_mux pdata field
> thermal: exynos: remove SoC type ifdefs
> thermal: exynos: remove __EXYNOS5420_TMU_DATA macro
> thermal: exynos: remove exynos_tmu_data.h include
>
> drivers/thermal/samsung/exynos_thermal_common.h | 1 -
> drivers/thermal/samsung/exynos_tmu.c | 706 +++++++++++++++++-------
> drivers/thermal/samsung/exynos_tmu.h | 131 +----
> drivers/thermal/samsung/exynos_tmu_data.c | 260 +--------
> drivers/thermal/samsung/exynos_tmu_data.h | 174 ------
> 5 files changed, 509 insertions(+), 763 deletions(-)
> delete mode 100644 drivers/thermal/samsung/exynos_tmu_data.h
>
> --
> 1.8.2.3
>

Attachment: signature.asc
Description: Digital signature