Re: commit message 8a5b20aebaa3 refers to non-existing commit ?

From: Paul Bolle
Date: Thu Jul 03 2014 - 18:06:29 EST


On Thu, 2014-07-03 at 14:48 -0700, David Rientjes wrote:
> On Thu, 3 Jul 2014, Toralf FÃrster wrote:
>
> > in
> > commit 8a5b20aebaa3d0ade5b8381e64d35fb777b7b355
> > Author: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> > Date: Wed Jul 2 15:22:35 2014 -0700
> >
> > slub: fix off by one in number of slab tests
> >
> >
> > you stated:
> >
> > Fixes 91cb69620284 ("slub: make dead memcg caches discard free slabs
> > immediately").
> >
> >
> > which I cannot find in main line currently. Pls could you point me to that commit ?
> >
>
> It hasn't been pushed to Linus yet, it's still sitting in the -mm tree:
> http://ozlabs.org/~akpm/mmotm/broken-out/slub-make-dead-memcg-caches-discard-free-slabs-immediately.patch
>
> Not sure where the SHA1 came from, probably linux-next.

Correct:
$ git tag --contains 91cb69620284f793928045714575cc7f6285c7f1
next-20140620
next-20140623
next-20140624
next-20140625

> So the fix made
> it to Linus before the offending commit, but the code is still correct.
Note that in today's linux-next (next-20140703) it appears to have a
different SHA1:
$ git log --no-merges --grep "slub: make dead memcg caches discard free slabs immediately"
commit a879a7e8c64a8d5594acaf665c4135be31ca6570
Author: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>
Date: Thu Jul 3 08:43:12 2014 +1000

slub: make dead memcg caches discard free slabs immediately

Since [...]

(Both commits appear to introduce identical changes. I have no idea what
those changes actually do.)


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/