Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

From: David Ahern
Date: Mon Apr 28 2014 - 10:58:03 EST


On 4/28/14, 7:16 AM, Namhyung Kim wrote:
2014-04-28 (ì), 12:01 +0200, Jiri Olsa:
On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote:
2014-04-17 (ë), 19:39 +0200, Jiri Olsa:
Keeping the data file description open for the whole life
of the dso object.

I suspect there might be an issue for reporting very large data file
with this approach - like open file limit?

I've got as high as ~200 openned file descriptors for
~2GB data of system wide monitoring

but right that could be an issue.. I wonder we could
workaround this somehow, because the speed up is quite
noticable

how about we monitor number of openned dso file descriptor
and once we cross this we close some portion of them

or something along those lines ;-)

Yeah, we'll need some way to control those eventually.

Handle EMFILE failures. Find an "old" one and close it to let the new one succeed.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/