Re: [PATCH 0/3] FTM PWM adds regmap and endianness support.

[Thierry Reding]

On Mon, Apr 28, 2014 at 02:26:57PM +0000, Li.Xiubo@xxxxxxxxxxxxx wrote:
> 
> 
> 
> > > Xiubo Li (3):
> > >   pwm: ftm-pwm: Clean up the code.
> > >   pwm: ftm-pwm: Convert to direct regmap API usage.
> > >   pwm: ftm-pwm: Add big-endian support
> > >
> > >  drivers/pwm/pwm-fsl-ftm.c | 96 ++++++++++++++++++++++++++---------------------
> > >  1 file changed, 53 insertions(+), 43 deletions(-)
> >
> > This leaves me with only very vague idea of why this is necessary and
> > why it should be merged.
> >
> > Please describe in more detail (in both the cover-letter and each
> > individual patch) why you want me to apply these patches.
> >
> 
> Thanks very much for your reply.
> 
> Should I resend this patch series? If so, I will add some thing like the following:
> 
> The FTM PWM driver will be used in our Vybrid, LS1 and LS2+ SoCs, and on Vybrid
> and LS2 SoCs, the FTM devices are in LE mode, while on LS1 SoCs it in BE mode.
> 
> So this patch series add endianness support based on the regmap core, which has
> already support the rich endiannesses for the same device.

Yes, please resend with that description added where appropriate. I'd
like to see something like that in the cover letter and, more
importantly, in the individual patches.

Thierry

Attachment: pgpd73iEqQNS_.pgp
Description: PGP signature